[vulkan] Dynamically load Vulkan loader library. Avoid Validation Layer crash on exit. #8289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 12, 2024 15:21
…solve the instance methods dynamically. Update the Vulkan readme to match the latest information regarding the SDK packages.
… be run on device
added 3 commits
June 13, 2024 15:51
when the runtime is compiled).
destructor which calls halide_vulkan_device_release() to avoid a segfault (at the cost of leaking!). See #8290. Refactor and cleanup halide_vulkan_device_release(). Add vk_destroy_context() methods.
derek-gerstmann
changed the title
derek-gerstmann
added
bug
dev_meeting
against device limits prior to compiling to verify shader compatibility.
|
Is this good to merge? I don't remember the conclusion from the dev meeting. |
|
Yes, this is good to merge and fixes most of the issues we were seeing. |
abadams
approved these changes
Jun 23, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @abadams , we should dynamically load the Vulkan loader library methods, and then use those to create an instance, rather than requiring a link-time dependency.
Also added runtime checks to verify the amount of shared memory required by the compiled pipeline is supported by the device. See #8288
Detect if VK_LAYER_KHRONOS_validation is enabled, and bypass the module destructor which calls halide_vulkan_device_release() to avoid a segfault (at the cost of leaking!). See: #8290.
Add vk_validate_shader_for_device() method to check shader bindings against device limits prior to compiling to verify shader compatibility. See: #8297 #8296 #8295 #8294 #8288