Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't track bounds through wrapping casts in simplifier #7813

Closed
wants to merge 3 commits into from
Closed

Don't track bounds through wrapping casts in simplifier #7813

wants to merge 3 commits into from

Conversation

abadams
Copy link
Member

@abadams abadams commented Aug 28, 2023

Fixes #7811

@steven-johnson steven-johnson self-requested a review August 28, 2023 22:45
@abadams
Copy link
Member Author

abadams commented Aug 28, 2023

I'll hold off on merging until #7814 is given the green light, because if that's a no-go, I'd have to roll this one back too.

@steven-johnson
Copy link
Contributor

This one is definitely clean in google.

@steven-johnson
Copy link
Contributor

ready to land?

@abadams
Copy link
Member Author

abadams commented Nov 28, 2023

Still depends on the fate of #7814

@abadams
Copy link
Member Author

abadams commented Aug 7, 2024

This code was overhauled to be more correct in #8222, so this PR is now irrelevant.

@abadams abadams closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fuzzer failure in fuzz_simplify
2 participants
@abadams @steven-johnson