Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow optional sorting of profiler output via HL_PROFILER_SORT env var (Fixes #7638) #7639

Merged
merged 13 commits into from
Aug 7, 2023
Merged

Allow optional sorting of profiler output via HL_PROFILER_SORT env var (Fixes #7638) #7639

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9b55ca2
Allow optional sorting of profiler output via HL_PROFILER_SORT env va…
steven-johnson Jun 15, 2023
99ebc69
trigger buildbots
steven-johnson Jun 16, 2023
7bc38e7
Merge branch 'main' into srj/profiler-sort
steven-johnson Jun 20, 2023
8be957a
Merge branch 'main' into srj/profiler-sort
steven-johnson Jun 23, 2023
01852bc
Merge branch 'main' into srj/profiler-sort
steven-johnson Jul 13, 2023
717876a
Update profiler_common.cpp
steven-johnson Jul 13, 2023
693deb8
Update float16_t.cpp
steven-johnson Jul 13, 2023
d005369
Update float16_t.cpp
steven-johnson Jul 13, 2023
11f61e9
Update float16_t.cpp
steven-johnson Jul 13, 2023
311d9af
Update float16_t.cpp
steven-johnson Jul 14, 2023
ab28f42
Merge branch 'main' into srj/profiler-sort
steven-johnson Jul 18, 2023
0bdde5a
Merge branch 'main' into srj/profiler-sort
steven-johnson Jul 19, 2023
d65e91a
Merge branch 'main' into srj/profiler-sort
steven-johnson Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 39 additions & 2 deletions src/runtime/profiler_common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,23 @@ WEAK void halide_profiler_memory_free(void *user_context,
WEAK void halide_profiler_report_unlocked(void *user_context, halide_profiler_state *s) {
StringStreamPrinter<1024> sstr(user_context);

int64_t (*compare_fs_fn)(halide_profiler_func_stats *a, halide_profiler_func_stats *b) = nullptr;

const char *sort_str = getenv("HL_PROFILER_SORT");
if (sort_str) {
if (!strcmp(sort_str, "time")) {
// Sort by descending time
compare_fs_fn = [](halide_profiler_func_stats *a, halide_profiler_func_stats *b) -> int64_t {
return (int64_t)b->time - (int64_t)a->time;
};
} else if (!strcmp(sort_str, "name")) {
// Sort by ascending name
compare_fs_fn = [](halide_profiler_func_stats *a, halide_profiler_func_stats *b) -> int64_t {
return strcmp(a->name, b->name);
};
}
}

for (halide_profiler_pipeline_stats *p = s->pipelines; p;
p = (halide_profiler_pipeline_stats *)(p->next)) {
float t = p->time / 1000000.0f;
Expand Down Expand Up @@ -366,6 +383,9 @@ WEAK void halide_profiler_report_unlocked(void *user_context, halide_profiler_st
}

if (print_f_states) {
int f_stats_count = 0;
halide_profiler_func_stats **f_stats = (halide_profiler_func_stats **)__builtin_alloca(p->num_funcs * sizeof(halide_profiler_func_stats *));

int max_func_name_length = 0;
for (int i = 0; i < p->num_funcs; i++) {
halide_profiler_func_stats *fs = p->funcs + i;
Expand All @@ -376,8 +396,6 @@ WEAK void halide_profiler_report_unlocked(void *user_context, halide_profiler_st
}

for (int i = 0; i < p->num_funcs; i++) {
size_t cursor = 0;
sstr.clear();
halide_profiler_func_stats *fs = p->funcs + i;

// The first func is always a catch-all overhead
Expand All @@ -386,6 +404,25 @@ WEAK void halide_profiler_report_unlocked(void *user_context, halide_profiler_st
continue;
}

f_stats[f_stats_count++] = fs;
}

if (compare_fs_fn) {
for (int i = 1; i < f_stats_count; i++) {
for (int j = i; j > 0 && compare_fs_fn(f_stats[j - 1], f_stats[j]) > 0; j--) {
auto *a = f_stats[j - 1];
auto *b = f_stats[j];
f_stats[j - 1] = b;
f_stats[j] = a;
}
}
}

for (int i = 0; i < f_stats_count; i++) {
size_t cursor = 0;
sstr.clear();
halide_profiler_func_stats *fs = f_stats[i];

sstr << " " << fs->name << ": ";
cursor += max_func_name_length + 5;
while (sstr.size() < cursor) {
Expand Down