Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid assigning to Buffer(Expr) by introducing an intermediate type. #7517

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Forbid assigning to Buffer(Expr) by introducing an intermediate type. #7517

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58890a3
Forbid assigning to Buffer(Expr) by introducing an intermediate type.
abadams Apr 17, 2023
0fcfb02
Simpler solution
abadams Apr 17, 2023
dfe07b0
Silence clang-tidy
abadams Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Buffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,16 +575,19 @@ class Buffer {
}
// @}

/** Make an Expr that loads from this concrete buffer at a computed coordinate. */
/** Make an Expr that loads from this concrete buffer at a computed
* coordinate. Returned Expr is const so that it's not possible to
* accidentally treat a buffer like a Func and try to assign an Expr to a
* given symbolic coordinate. */
// @{
template<typename... Args>
Expr operator()(const Expr &first, Args... rest) const {
const Expr operator()(const Expr &first, Args... rest) const { // NOLINT
std::vector<Expr> args = {first, rest...};
return (*this)(args);
}

template<typename... Args>
Expr operator()(const std::vector<Expr> &args) const {
const Expr operator()(const std::vector<Expr> &args) const { // NOLINT
return buffer_accessor(Buffer<>(*this), args);
}
// @}
Expand Down