-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug
shouldn't print entry/exit for parallel closures (but does)
#8184
Comments
I think this change was unintended. It crept in when we move lowering of parallel closures into lowering instead of codegen. I agree it should be fixed. |
Except the code looks like it's really just annotating the main LoweredFunc. I'll investigate. |
ok, it looks like this was actually an intentional change, because code for it was added to LowerParallelTasks.cpp |
abadams
added a commit
that referenced
this issue
Apr 9, 2024
abadams
added a commit
that referenced
this issue
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What it says on the tin -- it makes the
debug
feature near-useless if you have any parallelism in your schedule. Maybe it's useful for some corner cases but I haven't yet encountered such a case. Can we default it to off for these?The text was updated successfully, but these errors were encountered: