Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug shouldn't print entry/exit for parallel closures (but does) #8184

Closed
steven-johnson opened this issue Apr 9, 2024 · 3 comments · Fixed by #8185
Closed

debug shouldn't print entry/exit for parallel closures (but does) #8184

steven-johnson opened this issue Apr 9, 2024 · 3 comments · Fixed by #8185

Comments

@steven-johnson
Copy link
Contributor

What it says on the tin -- it makes the debug feature near-useless if you have any parallelism in your schedule. Maybe it's useful for some corner cases but I haven't yet encountered such a case. Can we default it to off for these?

@abadams
Copy link
Member

abadams commented Apr 9, 2024

I think this change was unintended. It crept in when we move lowering of parallel closures into lowering instead of codegen. I agree it should be fixed.

@abadams
Copy link
Member

abadams commented Apr 9, 2024

Except the code looks like it's really just annotating the main LoweredFunc. I'll investigate.

@abadams
Copy link
Member

abadams commented Apr 9, 2024

ok, it looks like this was actually an intentional change, because code for it was added to LowerParallelTasks.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants