-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm_cpu_features.cpp is a no-op #7979
Comments
I looked into this recently, and the state of host cpu feature sniffing on arm is woeful. There's an instruction for it, but it's privileged so user code can't run it. I checked xnnpack because I know it makes per-cpu decisions about what code to run, and it uses https://github.com/pytorch/cpuinfo which literally opens /proc/cpuinfo as a file and parses the string on linux-like targets. |
The Golang runtime uses hwcap bits for Android and |
https://github.com/google/cpu_features is fairly well elaborated. I doubt we want to make it a dependency, but maybe providing the glue code to use it as an optional thing to add to one's build would be useful. |
Does this apply to AArch64, too? I see there's a comment in
But isn't |
Yes it does. The main problem here is that it fails to turn on armdotprod. I think that comment is from before we added dot product support. |
See #7901 |
…elease/18.x) (#8343) Detect ARM CPU features for host target and in runtime (#8298) Adds feature detection for ARM CPUs to the runtime library and to the host target feature computation. Supports Windows, macOS, Linux, iOS, and Android. Also fix bug in Type::max() and Type::min() for float16. Fixes #4727 Fixes #6106 Fixes #7901 Fixes #7979 Fixes #8340 Co-authored-by: Alex Reinking <[email protected]>
We don't attempt to detect any features of the host CPU on arm; surely we can do better, at least on Android.
The text was updated successfully, but these errors were encountered: