Update package.json #1725
Closed
Update package.json #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix engine version which could make more compatibility to new node version
fix engine number to allow greater node version to install
bnjmnt4n
reviewed
Nov 9, 2016
| @@ -19,7 +19,7 @@ | |||
| "url": "git://github.com/hakimel/reveal.js.git" | |||
| }, | |||
| "engines": { | |||
| "node": "~4.1.1" | |||
| "node": ">=4.1.1" | |||
There was a problem hiding this comment.
Can we make this >=4.0.0?
bnjmnt4n
added a commit
to bnjmnt4n/reveal.js
that referenced
this pull request
Dec 6, 2016
The development workflow can be used with Node 4+, not just Node 6. We should avoid showing warnings and errors when users are installing this package via npm/yarn. Ref. hakimel#1729, hakimel#1743. Closes hakimel#1725.
SteveDesmond-ca
pushed a commit
to SteveDesmond-ca/presentations
that referenced
this pull request
Apr 19, 2017
The development workflow can be used with Node 4+, not just Node 6. We should avoid showing warnings and errors when users are installing this package via npm/yarn. Ref. hakimel#1729, hakimel#1743. Closes hakimel#1725.
SteveDesmond-ca
pushed a commit
to SteveDesmond-ca/presentations
that referenced
this pull request
Apr 19, 2017
The development workflow can be used with Node 4+, not just Node 6. We should avoid showing warnings and errors when users are installing this package via npm/yarn. Ref. hakimel#1729, hakimel#1743. Closes hakimel#1725.
derheap
pushed a commit
to derheap/reveal.js
that referenced
this pull request
Feb 22, 2018
The development workflow can be used with Node 4+, not just Node 6. We should avoid showing warnings and errors when users are installing this package via npm/yarn. Ref. hakimel#1729, hakimel#1743. Closes hakimel#1725.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix engine version which could make more compatibility to new node version