Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speaker notes won't show slides if presentation url contains question mark #1392

Closed
lizatop opened this issue Oct 9, 2015 · 2 comments
Closed
Labels

Comments

@lizatop
Copy link

lizatop commented Oct 9, 2015

When I have a reveal.js presentation opened with a ? in the URL, I can not get the slides in the speaker notes loaded, because the iframes url's params are appended with a ? and browsers do not like two question marks in an URL.

Suggested fix in /plugin/notes/notes.html.

change :

var currentURL = data.url + '?' + params + '&postMessageEvents=true' + hash;
var upcomingURL = data.url + '?' + params + '&controls=false' + hash;

to :

var urlSep = (data.url.indexOf('?') > 0) ? '&' : '?';
var currentURL = data.url + urlSep + params + '&postMessageEvents=true' + hash;
var upcomingURL = data.url + urlSep + params + '&controls=false' + hash;
@FranceBaril
Copy link

Using 3.2.0, I can open the slides in the speaker notes when path has ? in Safari, but the parameters are not passed/applied properly.

@bnjmnt4n
Copy link
Collaborator

bnjmnt4n commented Mar 7, 2016

Closed by #1522.

@bnjmnt4n bnjmnt4n closed this as completed Mar 7, 2016
hakimel added a commit that referenced this issue Mar 9, 2016
MarcoHengstenberg pushed a commit to MarcoHengstenberg/reveal.js that referenced this issue Jun 2, 2016
* Add support for custom notes.html file

It would be nice if we could define a custom notes.html file.

Actually, I'm used to compile my js files before releasing my app and, using selectors like `script[src$="notes.js"]`, doesn't work :(

So, what do you think about it?

* Fixed last header having a border-bottom 

`<tbody/>` is automatically inserted, so we can guarantee that this affects all ths and tds in the last row of the table *body* and the head is left untouched

* Gruntfile.js: watch tasks restructured

* add option to mute background videos

* bug fix - when the first section has a background-video, the vido do not execute. Now, it's work

* improvement on spaces and indentation

* Improvement of code. Now none flag is used, but the readyState property  from video element

* UPDATED - Improvement of code. Now none flag is used, but the readyState property  from video element

* UPDATED - Improvement on spaces and indentation

* UPDATED - Improvement on spaces and indentation

* format note content when creating slide

In html content, marked allow `Inline-Level Grammar` but not `Block-Level Grammar`, so when I write following:
```
note:
* a
* b
* c
```
it become:
```html
<p><em> a
</em> b</p>
<ul>
<li>c</li>
</ul>
```
unbelievable!

* fixed loading

* Add autoSlideRight option

When the autoSlideRight config option is active, the auto-sliding
will always navigate to the right and never down even if slides are
present there. This allows hidden "bonus slides" in presentations
which can be displayed as needed but won't show up automatically.

* Add a more flexible autoSlideMethod option

Auto-sliding will now use the method specified in the config if it is
a function or default to navigateNext.

* Fix build error

* add autoSlideMethod to default config

* 2x playback controls for retina displays

* tweak

* Added 4 fragment transitions effect.

* Clean version of the new transitions.

* add option to mute background videos (updated)

* update to highlight.js 9.0.0

* expose version number through  hakimel#1451

* add new fragment styles to readme hakimel#1445

* center help overlay with flexbox

* tweaked fragment examples

* include speaker view keyboard shortcut when applicable hakimel#1466

* rebuild css

* same code format

* fix broken iframe in backgrounds example

* code format

* Change ".video" to ".reveal .video"

I don't know if this is supposed to be this way ?

* use css  to scale slides up in safari

* Remove unused dependencies.

* Fix query parameter issue in notes plugin.

Closes hakimel#1392.

* Make PDF export section less OS X specific.

Closes hakimel#1073.

* fix notes regex hakimel#1522 hakimel#1392

* notes plugin no longer syncs overview mode hakimel#1446

* server notes plugin no longer syncs overview mode hakimel#1446

* update headjs to v1.0.3

* add 'shuffle' config value and API method hakimel#1506 hakimel#1089

* new empty template at index.html, move old index to demo.html hakimel#1526

* remove unintentionally added file

* minor tweaks

* Table of contents added in README.md

* generalize scroll offset prevention

* Update README.md

readme tweaks

* Update README.md

* support for standalone multiplexing

* remove test content

* new multiplex server courtesy of now.sh (closes hakimel#1377)

* Fixes hakimel#1549, now UA match is limiting out MS Edge and Chrome detection is improved. Also improved UserAgent access by storing it in to a local variable, it was accessed so many times in different places.

* Fix watching for markdown files

`./*.md` didn't work `*.md` does work

* lazy load iframe in demo

* widen watch for html files, required for updates to demo.html

* overview now works with percentage based width/height hakimel#1247

* readme tweak for hakimel#1535

* change introduction

* 3.3.0

* Simplify full setup

* Update README.md

more in-depth documentation of slide backgrounds hakimel#1542
SteveDesmond-ca pushed a commit to SteveDesmond-ca/presentations that referenced this issue Apr 19, 2017
SteveDesmond-ca pushed a commit to SteveDesmond-ca/presentations that referenced this issue Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants