Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1220 configurable drawer button #1491

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

linusfj
Copy link
Member

@linusfj linusfj commented Mar 20, 2024

Closes #1220.

Updated to include configurable settings for the Drawer button. This includes drawer title, button title, and button icon.
- Add predefined icons that can be selected in the admin UI.
- Update source data using a different object in the config file.
Add settings to configure:
- Drawer title
- Button title
- Button icon
@Hallbergs
Copy link
Member

Is it by design you only allow for two icons? If we're making the button configurable, maybe we should allow for any icon?

@linusfj
Copy link
Member Author

linusfj commented Mar 26, 2024

In the current version, we only allow for two icons, but expanding this to any icon is a good idea for later iterations.

@Hallbergs Hallbergs self-requested a review April 3, 2024 08:14
Copy link
Member

@Hallbergs Hallbergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I would be much happier to see possibility to choose icon more freely.

@jacobwod jacobwod merged commit 15be06d into develop Apr 3, 2024
@jacobwod jacobwod deleted the feature/1220-configurable-drawer-button branch April 3, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants