-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New repo structure #1488
New repo structure #1488
Conversation
… dir. Also, created scripts/ and moved the relevant files to that dir.
@jacobwod Looks good! I've been thinking for a long time that the "new-" is getting old in the meanwhile. 😃 A clean structure is a really good idea and for my part I like the new structure on an overview level. Maybe complemented by a top |
I agree @sweco-semara. Regarding the new "home" for our community extensions/plugins - I think it's been overlooked. It's good you mention it. I think there are at least two mutually exclusive solutions: either a) in other forks, outside of the main repo (kind of disorganised, people can put their contributions wherever they want), or b) as a top-level If we go for B: should we allow back-merging of community extensions to the main repo, or just leave Just a quick tip for those of you wanting to test this branch: I highly recommend cloning it into a separate directory on your local computer in order to avoid directories being created and disappearing when you switch branches. Next you could run |
…are not tested, please test and fix any potential issues.
…ult in DocumentHandler, as added in #881.
UPDATE AFTER MERGE TO DEVELOP
This merge is now complete. However: after you pull the latest develop, there's a good chance that you will still have the
new-*
directories on your drive. The reason is that even though those directories have been moved toapps/
and renamed, some of its contents were previously ignored (by.gitignore
). Examples include installednode_modules
, log files, your local map configurations inApp_Data
, etc. Make sure to control what's left, move whatever you want to keep to the new locations and finally **delete thenew-*
directories.This project has for a long time in fact been some kind of a monorepo, with multiple applications scattered around the root directory, accompanied by some helper scripts, build files and documentation. I propose we clean this up a bit. The goals are:
apps
folder - that what I propose to stick to)new-
prefix on our appsThis PR is not ready for a merger yet, please leave your input below or push changes directly to PR branch.
I wouldn't want to complicate any ongoing development or break custom build scripts, so let's collaborate on this one. 🤝
UPDATE:
I realise this PR is rather large, so here's a more visual view of the changes as proposed at time of writing.