Opportunity to disable stroke for drawtypes "Circle" & "Polygon" #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallbergs
requested changes
Feb 28, 2024
| })); | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [props.activeDrawType, props.drawStyle]); |
There was a problem hiding this comment.
I would suggest that you destructure the props outside the useEffect and remove the eslint-disable row!
Something like:
const {activeDrawtype, drawStyle} = props;
useEffect(() => {...}, [activeDrawtype, drawStyle])There was a problem hiding this comment.
Cheers! I'll make sure to remove the eslint-disable rows in the #1460 PR aswell.
Hallbergs
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1177
Note: Additionally, I've conducted tests to verify the consistency of the stroke value 'none'/stroke style by exporting to a KML file and importing it across various software platforms, aside from Hajk. This was done to ensure alignment with the expected behavior across different environments.