Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LayerComparer: make it easier to change layers #1543

Open
jacobwod opened this issue Aug 30, 2024 · 0 comments
Open

LayerComparer: make it easier to change layers #1543

jacobwod opened this issue Aug 30, 2024 · 0 comments
Assignees
@jacobwod
Labels
module:client/plugin Functionality that goes into plugins in client
Milestone
4.0

Comments

@jacobwod
Copy link
Member

LayerComparer has been around for two years now, ever since #687. The tool works fine for most use cases, but there are situations where it can be improved. One example is when user wants to quickly change which layers are being compared. The only way to re-activate the Dialog is via the usual button in Drawer/Widget.

One easier way would be to add a button to the overlay that shows up while comparing:
Skärmavbild 2024-08-30 kl 13 54 51
@jacobwod jacobwod added the module:client/plugin Functionality that goes into plugins in client label Aug 30, 2024
@jacobwod jacobwod added this to the 3.x milestone Aug 30, 2024
@jacobwod jacobwod self-assigned this Aug 30, 2024
jacobwod added a commit that referenced this issue Aug 30, 2024
@jacobwod
Implemented the ideas described in #1543:
b850bae 
- Semi-major rewrite of the plugin, as it turned out that a listener (for the event on globalObserver) and a callback (to the DialogWindowPlugin component) were needed.
- Also some bugfixes related to restoring the original background layer.
- Certainly, still room for improvement.
jacobwod added a commit that referenced this issue Sep 2, 2024
@jacobwod
Implemented the ideas described in #1543: (#1544)
33cedc3 
- Semi-major rewrite of the plugin, as it turned out that a listener (for the event on globalObserver) and a callback (to the DialogWindowPlugin component) were needed.
- Also some bugfixes related to restoring the original background layer.
- Certainly, still room for improvement.
@jacobwod jacobwod modified the milestones: 3.x, 4.0 Sep 2, 2024
jacobwod added a commit that referenced this issue Sep 2, 2024
@jacobwod
Updated changelog to reflect #1543.
b02e40d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobwod jacobwod

Labels
module:client/plugin Functionality that goes into plugins in client
Projects
Hajk
Status: Done
Milestone
4.0
Development

No branches or pull requests
1 participant
@jacobwod