Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to upgrade to latest remark-markdown #1425

Closed
jacobwod opened this issue Oct 30, 2023 · 0 comments
Closed

Make it possible to upgrade to latest remark-markdown #1425

jacobwod opened this issue Oct 30, 2023 · 0 comments
Assignees
@jacobwod
Labels
dependencies Pull requests that update a dependency file
Milestone
3.13

Comments

@jacobwod
Copy link
Member

jacobwod commented Oct 30, 2023 •
edited
Loading

If we only bump the packages as of now, we get a weird scenario where the children property on p suddenly is a string, rather than an Array, as in current (previous) version.

So this:
Skärmavbild 2023-10-30 kl 14 57 14

Turns into this:
Skärmavbild 2023-10-30 kl 14 53 31

Making this code crash:
Skärmavbild 2023-10-30 kl 14 59 28

I addition, certain props have been removed, see here. This requires some manual fixes too.
@jacobwod jacobwod added the dependencies Pull requests that update a dependency file label Oct 30, 2023
@jacobwod jacobwod added this to the 3.x milestone Oct 30, 2023
@jacobwod jacobwod self-assigned this Oct 30, 2023
jacobwod added a commit that referenced this issue Oct 30, 2023
@jacobwod
Upgraded deps, among those react-markdown, which required some work. C…
1146876 
…loses #1425.
@jacobwod jacobwod modified the milestones: 3.x, 3.13 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobwod jacobwod

Labels
dependencies Pull requests that update a dependency file
Projects
Hajk
Status: Done
Milestone
3.13
Development

No branches or pull requests
1 participant
@jacobwod