You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hajk client will currently always log the silent warning re. missing plugins in map config to the console, regardless if the config is clean/only contains active tools.
This bug is cosmetic only, mostly for developers or admins wanting to check that the Hajk config is correct. Current state is a bit confusing, but the map will still load without issues.
To Reproduce
Clean up a map configuration, make sure no inactive or invalid plugins are referenced
Open the browser console
(Re-)load the map
Check browser console
Expected behavior
Expect console to be quiet/empty if no errors.
Actual
The map configuration contains unavailable plugins: . Please check your map config and buildConfig.json.
Suggested fix
It seems there is a hard assumption in App.js that const unsupportedToolsFoundInMapConfig will always be set/contains at least one value. Suggested fix is to guard the join + console log operation on L397 in current master to not log if unsupportedToolsFoundInMapConfig is indeed empty.
The text was updated successfully, but these errors were encountered:
sweco-semara
changed the title
Client console logging assumes missing plug-ins in configuration
Client unsupported tools check assumes map configuration contains at least one missing tool
Aug 31, 2023
sweco-semara
changed the title
Client unsupported tools check assumes map configuration contains at least one missing tool
Client unsupported plugins check assumes map configuration contains at least one missing plugin
Aug 31, 2023
Hajk client will currently always log the silent warning re. missing plugins in map config to the console, regardless if the config is clean/only contains active tools.
This bug is cosmetic only, mostly for developers or admins wanting to check that the Hajk config is correct. Current state is a bit confusing, but the map will still load without issues.
To Reproduce
Expected behavior
Expect console to be quiet/empty if no errors.
Actual
Suggested fix
It seems there is a hard assumption in App.js that const
unsupportedToolsFoundInMapConfig
will always be set/contains at least one value. Suggested fix is to guard the join + console log operation on L397 in current master to not log if unsupportedToolsFoundInMapConfig is indeed empty.The text was updated successfully, but these errors were encountered: