Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pending dependency upgrade needs action: react-number-format #1207

Closed
jacobwod opened this issue Oct 7, 2022 · 0 comments
Closed

Pending dependency upgrade needs action: react-number-format #1207

jacobwod opened this issue Oct 7, 2022 · 0 comments
Assignees
@jacobwod
Labels
dependencies Pull requests that update a dependency file
Milestone
3.13

Comments

@jacobwod
Copy link
Member

jacobwod commented Oct 7, 2022

I'm about to bump some dependencies in develop, but this one needs some attention due to changed API.

  ◉ react-number-format              ^4.9.4  →  ^5.0.1

Can @linusfj have a look? Here is some helpful info: https://s-yadav.github.io/react-number-format/docs/migration/.

Consider removing this dependency entirely as thousand separator formatting can be achieved more easily using the Intl API. E.g. try:

> new Intl.NumberFormat('sv-SE').format(1234567.1234567)
< "1 234 567,123"
@jacobwod jacobwod added the dependencies Pull requests that update a dependency file label Oct 7, 2022
@jacobwod jacobwod added this to the 3.x milestone Oct 7, 2022
@linusfj linusfj self-assigned this Oct 10, 2022
@jacobwod jacobwod assigned jacobwod and unassigned linusfj Aug 17, 2023
jacobwod added a commit that referenced this issue Aug 17, 2023
@jacobwod
Fixed what was necessary to upgrade react-number-format. Didn't have …
c591e92 
…time to properly replace this (as we seem to use it solely for the thousands separator) as I suggested elsewhere. Nevertheless, closes #1207.
@jacobwod jacobwod modified the milestones: 3.x, 3.13 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobwod jacobwod

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
3.13
Development

No branches or pull requests
2 participants
@jacobwod @linusfj