[notebook2] libsass depends on a c++ compiler

[danking]

notebook2 deploys are currently broken, which breaks all deploys

[chrisvittal]

Unfortunately, the only way to check if this actually works right now is for deploy to succeed. 😞

[akotlar]

Pushed a similar fix a few minutes ago, good timing.

[akotlar]

Unfortunately, the only way to check if this actually works right now is for deploy to succeed. 😞

Can't you check by building the docker image?

[danking]

@akotlar is right, I tested this locally.

[akotlar]

@danking btw, we can drop the pip <19 req: pypa/pip#6197

[danking]

#5482 :P

[akotlar]

#5482 :P

Haha man we're on the same wavelength today: akotlar@c0c3751
(g++ is a neater solution, I was going to test that next)

[chrisvittal]

Well yes. What I mean is in an automated fashion. We haven't deployed any builds in around a day because of this error, the deploy job keeps restarting and it was very difficult for me to interrogate what was going on.

[akotlar]

Well yes. What I mean is in an automated fashion. We haven't deployed any builds in around a day because of this error, the deploy job keeps restarting and it was very difficult for me to interrogate what was going on.

yeah, sorry, that's on me. I didn't notice because the pod's log didn't change between the first PR, which didn't have libsass, and the next, which did; assumed CI hadn't deployed it because it was backed up.