Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove Iris and M Franklin from authorized users and teams lists #14704

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

cjllanwarne
Copy link
Collaborator

Change Description

Seems like only yesterday that we had #14668

Also removes @illusional as I believe he's no longer in a contributing role (... but please shout out if you disagree! And cc @jmarshall)

Security Assessment

  • This change has a high security impact
    • Required: and the impact has been assessed and approved by appsec
  • This change has a medium security impact
  • This change has a low security impact
  • This change has no security impact

Description of the security impact and necessary mitigations:

Removes entries from the allow-list of contributors and recommended reviewers.

@@ -26,8 +26,6 @@ def __init__(self, gh_username: str, hail_username: Optional[str] = None, teams:
User('chrisvittal', 'cvittal', HAIL_TEAM),
User('cjllanwarne', 'chrisl', HAIL_TEAM),
User('ehigham', 'ehigham', HAIL_TEAM),
User('illusional', 'mfrankli'),
User('iris-garden', 'irademac', HAIL_TEAM),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@jmarshall
Copy link
Contributor

👍 (Thanks for the CC.)

Copy link
Member

@ehigham ehigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:'(

@hail-ci-robot hail-ci-robot merged commit 5b4be59 into hail-is:main Sep 30, 2024
3 checks passed
@cjllanwarne cjllanwarne deleted the cjl_iris_out branch September 30, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants