Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hailtop] Dont assume exact error message match for ClientPayloadError retrying #14545

Conversation

daniel-goldstein
Copy link
Contributor

@daniel-goldstein daniel-goldstein commented May 10, 2024

The treatment of ClientPayloadError as a sometimes transient error was originally made in response to an existing issue in aiohttp that can cause transient errors on the client that are difficult to distinguish from a real broken server. What's in main matched exactly on the error message, but that error message has since changed to include more information, breaking our transient error handling. This change relaxes the requirement of the error response string to fix transient error handling for our current version of aiohttp.

I wish I had a better approach. ClientPayloadError can also be thrown in the case of malformed data, so I am reticent to treat it as always transient, but we could perhaps make it a limited_retries_error and avoid inspecting the error message.

@hail-ci-robot hail-ci-robot merged commit c6b7be9 into hail-is:main May 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants