[hailtop] Dont assume exact error message match for ClientPayloadError retrying #14545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The treatment of
ClientPayloadError
as a sometimes transient error was originally made in response to an existing issue in aiohttp that can cause transient errors on the client that are difficult to distinguish from a real broken server. What's inmain
matched exactly on the error message, but that error message has since changed to include more information, breaking our transient error handling. This change relaxes the requirement of the error response string to fix transient error handling for our current version ofaiohttp
.I wish I had a better approach.
ClientPayloadError
can also be thrown in the case of malformed data, so I am reticent to treat it as always transient, but we could perhaps make it alimited_retries_error
and avoid inspecting the error message.