Fix coreGreenberet/homematicip-rest-api#409 #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing issue hahn-th#409 Co-Authored-By: Hoytron <[email protected]>
web-dc
approved these changes
May 25, 2021
|
thanks for the PR. |
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
=======================================
Coverage 96.52% 96.53%
=======================================
Files 42 42
Lines 8315 8336 +21
=======================================
+ Hits 8026 8047 +21
Misses 289 289
Continue to review full report at Codecov.
|
|
thx |
schiegg
referenced
this pull request
in schiegg/home-assistant-core
Jul 3, 2021
Pull request home-assistant#51407 addresses the changes done in coreGreenberet/homematicip-rest-api#410 only by updating the dependency to the newer released version of it, making it aware of the new channel indexes. However it currently fails the integration checks [as mentioned by @frenck](home-assistant#51407 (review)). It seems that the local homeassistant test suite also has a dedicated version of the test data written [here](https://github.com/coreGreenberet/homematicip-rest-api/blob/d7c1b2c231603603b543e57eff1c0bcd6fd5e268/homematicip_demo/json_data/home.json#L8598). So maybe we also have to manually sync these changes.
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for channel parsing in SECURITY_ZONES and SECURITY_AND_ALARM
Co-Authored-By: Hoytron [email protected]