absl status handling of message to json string

hafenkran · Oct 25, 2024 · a32a54f · a32a54f
1 parent 4488018
commit a32a54f
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/src/bigquery_jobs.cpp b/src/bigquery_jobs.cpp
@@ -2,6 +2,7 @@
 #include "duckdb/main/attached_database.hpp"
 #include "duckdb/main/database_manager.hpp"
 #include "duckdb/parser/parsed_data/create_table_function_info.hpp"
+#include "absl/status/status.h"
 
 #include <google/protobuf/util/json_util.h>
 
@@ -174,17 +175,26 @@ static void MapJobToRow(const T &job, DataChunk &output, idx_t &out_idx) {
 
     // statistics
     std::string json_output;
-    google::protobuf::util::MessageToJsonString(job_stats, &json_output);
+    absl::Status status = google::protobuf::util::MessageToJsonString(job_stats, &json_output);
+	if (!status.ok()) {
+		throw BinderException("Failed to convert job statistics to JSON");
+	}
     output.SetValue(value_idx++, out_idx, Value(json_output));
 
     // configuration
     std::string configuration_json;
-    google::protobuf::util::MessageToJsonString(job.configuration(), &configuration_json);
+    status = google::protobuf::util::MessageToJsonString(job.configuration(), &configuration_json);
+	if (!status.ok()) {
+		throw BinderException("Failed to convert job configuration to JSON" );
+	}
     output.SetValue(value_idx++, out_idx, Value(configuration_json));
 
     // status
     std::string status_json;
-    google::protobuf::util::MessageToJsonString(job.status(), &status_json);
+    status = google::protobuf::util::MessageToJsonString(job.status(), &status_json);
+	if (!status.ok()) {
+		throw BinderException("Failed to convert job status to JSON");
+	}
     output.SetValue(value_idx++, out_idx, Value(status_json));
 }