Fix warning in ToRESTMapper()

haf · Jun 19, 2021 · 17c9948 · 17c9948
1 parent c2cb93c
commit 17c9948
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/utils/kubectl/kubectl.go b/utils/kubectl/kubectl.go
@@ -64,14 +64,14 @@ func (p *KubeProvider) ToDiscoveryClient() (discovery.CachedDiscoveryInterface,
 }
 
 func (p *KubeProvider) ToRESTMapper() (meta.RESTMapper, error) {
-	discoveryClient, _ := p.ToDiscoveryClient()
-	if discoveryClient != nil {
-		mapper := restmapper.NewDeferredDiscoveryRESTMapper(discoveryClient)
-		expander := restmapper.NewShortcutExpander(mapper, discoveryClient)
-		return expander, nil
+	discoveryClient, err := p.ToDiscoveryClient()
+	if err != nil {
+		return nil, fmt.Errorf("p.ToDiscoveryClient() failed - no restmapper available")
 	}
 
-	return nil, fmt.Errorf("no restmapper")
+	mapper := restmapper.NewDeferredDiscoveryRESTMapper(discoveryClient)
+	expander := restmapper.NewShortcutExpander(mapper, discoveryClient)
+	return expander, nil
 }
 
 const (