Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Feature/additional motions take2 #60

Closed

Conversation

jhgarner
Copy link

@jhgarner jhgarner commented Apr 6, 2021

This adds all of the motions that were included in the original pull request. The code is heavily refactored and shouldn't include any breaking changes.

#59 should probably be merged in first but I'm opening this request now in case you want to see the end result. Hopefully this is the right way to split up the work but let me know if that's not the case.

Jack Garner added 2 commits April 6, 2021 10:23
These options include controlling which direction of the cursor motions
apply to, whether they operate on entire lines, and whether the motion
only applies to the current line.

This branch adds the work needed to make more complicated motions
possible.
This adds new motions to better align with the features offered by
easymotion. The motions include ones for moving up or down lines in the
file, moving to the begining or end of words, and moving towards
characters on a given line.
@weilbith
Copy link

I'm really awaiting this. Are there any updates for it?

@jhgarner
Copy link
Author

I'm waiting on a response to #59 which needs to be finished first. After that, I can rebase this request and hopefully it'll be merged soon after.

It's pretty easy to get something like Plug to use a different fork/branch in case you want to test this before it's merged.

@weilbith
Copy link

It's pretty easy to get something like Plug to use a different fork/branch in case you want to test this before it's merged.

True. Maybe I should try that as long as there are no other crucial merges in-between 😬
So does this PR work on top of #59 or can I go straight for this feature branch here?

@jhgarner
Copy link
Author

You should be able to go straight for this feature branch. I'm not sure if it was the right way to do it, but this branch includes the commits from the other.

@hadronized
Copy link
Owner

Thanks for the PR. Unfortunately, I’m going to close this, as the initial PR you based your work from was superseded by #93, which brings in most of the commands you implemented here.

@hadronized hadronized closed this Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants