Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

hard to distinguish between q and g with underline #70

Closed
iqxd opened this issue Apr 16, 2021 · 6 comments
Closed

hard to distinguish between q and g with underline #70

iqxd opened this issue Apr 16, 2021 · 6 comments

Comments

@iqxd
Copy link

iqxd commented Apr 16, 2021

when set fonts like JetBrains Mono and Hack , etc

Hack Font:
image

JetBrains Mono:
image

@pockata
Copy link

pockata commented Apr 24, 2021

Hey @iqxd, I also use JetBrains Mono and had a similar issue.
I solved it by changing the keys configuration to remove q and o and leave only g and p by doing

require'hop'.setup({
	keys = 'asdghklwertyuipzxcvbnmfj',
})

@iqxd
Copy link
Author

iqxd commented Apr 25, 2021

Thanks @pockata , it helps on this issue currently .
However, I think it's better if there's an option to disable/enable underlined on key chars.

@hadronized
Copy link
Owner

Hey, you can change all the highlights, no need to switch the keys for that. We can change the default highlights by removing the underline if people think it’s too disturbing.

@pockata
Copy link

pockata commented Apr 27, 2021

Thanks, @phaazon, I just looked at the highlight groups in the source code and setting highlight HopNextKey gui=bold removes the underline (defaulting to gui=bold,underline). Now there's no need to alter the keys configuration.

Perhaps documenting the highlight groups in the README/help files so users know they can easily change the look of Hop?

Edit: Hop applies the highlights when you change the colorscheme, so an autocmd would be needed to keep the underline disabled:
autocmd ColorScheme * highlight HopNextKey gui=bold

@hadronized
Copy link
Owner

Yeah the autocommand will remove and replace them. The joy of theming in Neovim.

hadronized added a commit that referenced this issue Jun 1, 2021
Those are confusing with some fonts. In the next commit, we should be
able to override highlightings more correctly, especially via
autocommands.

Relates to #70.
hadronized added a commit that referenced this issue Jun 1, 2021
This allows to enable or disable inserting highlighting autocommands.

Relates to #70.
@hadronized
Copy link
Owner

I removed the underline, it was a bad default, and documented how to customize the highlights. I’ve also allowed people to disable the autocommands.

yehuohan pushed a commit to yehuohan/hop.nvim that referenced this issue Apr 22, 2024
* feat: add windows-list to allow custom window candidates

* fix: always check focusable window
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants