Feature: Recursive dir check - Lint multiple files #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry for the late review. Can you please fix the merge conflicts? |
|
Hello, no worries about the timing, I've resolved the conflicts so far |
|
@itamargiv any news? |
I'd say we have to ask @lorenzo to re-review |
|
thanks! |
addshore
added a commit
to wmde/wikibase-release-pipeline
that referenced
this pull request
Feb 18, 2022
hadolint/hadolint-action#34 was merged and released, so we can make use of this rather than the custom version.
toban
pushed a commit
to wmde/wikibase-release-pipeline
that referenced
this pull request
Feb 22, 2022
hadolint/hadolint-action#34 was merged and released, so we can make use of this rather than the custom version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve the issue mentioned in #3. Although a simpler solution would be to try and enable passing glob patterns directly into the
dockerfileparameter, it seems as though GH Actions passes these parameters to the entry point as strings which cannot be expanded without usingevalwhich seemed a little risky to me.I would be happy for any suggestion on how to improve this, as it might not be a complete solution, but was enough for my use case in wmde/wikibase-release-pipeline/pull/183.