Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approaching 90% coverage #248

Merged
merged 13 commits into from
Apr 10, 2015
Merged

Approaching 90% coverage #248

merged 13 commits into from
Apr 10, 2015

Conversation

krlmlr
Copy link

@krlmlr krlmlr commented Apr 8, 2015

Testing is fun!

@hadley
Copy link
Owner

hadley commented Apr 8, 2015

Can you add a bullet to news about deprecating liply()? (I assume because it doesn't work?)

@krlmlr
Copy link
Author

krlmlr commented Apr 8, 2015

liply(): I haven't tried if it works, but I have found zero matches on GitHub (which means all packages on CRAN) and no internal tests. This is intended as a honest statement that the code is there but you're on your own, given the now stable state of plyr. Do you prefer another solution?

@hadley
Copy link
Owner

hadley commented Apr 8, 2015

@krlmlr yeah that's fine - it just needs a note in the news.

hadley added a commit that referenced this pull request Apr 10, 2015
@hadley hadley merged commit dfaa738 into hadley:master Apr 10, 2015
@hadley
Copy link
Owner

hadley commented Apr 10, 2015

Thanks! Still no luck with turning coveralls on, and no response from support

@krlmlr krlmlr deleted the coverage2 branch April 10, 2015 19:56
@krlmlr
Copy link
Author

krlmlr commented Apr 10, 2015

That's too bad. http://codecov.io is good as well but needs an (encrypted) token that you'll have to add to .travis.yml.

@krlmlr
Copy link
Author

krlmlr commented Apr 11, 2015

Coveralls: Trying to look at coverage for dplyr at https://coveralls.io/builds/2263666/source?filename=.%2FR%2Ftally.R, I saw the following:

SOURCE NOT AVAILABLE
The owner of this repo needs to re-authorize with Github; their OAuth credentials are no longer valid so the file cannot be pulled from the Github API.

@hadley
Copy link
Owner

hadley commented Apr 13, 2015

Thanks - that was the hint I needed. I revoked access in github and reauthed, and now it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants