Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed a way to check if .expr is function #162

Closed
wants to merge 1 commit into from

Conversation

everpeace
Copy link

changed a way to check if expr is function in such a way that .expr
will not be evaluated.

#158

changed a way to check if expr is function in such a way that .expr
will not be evaluated.
@crowding
Copy link
Contributor

This checks for invocations of the form r_ply(n, function() expr) but I would have guessed that the intention of r_ply's DWIM was to catch invocations of the form

fn <- function() {...}
r_ply(n, fn)

which now generate an error with this patch.

We probably also want to maintain consistency between r_ply rlply raply and rdply.

@everpeace
Copy link
Author

Thanks for pointing out a bug of my code.
I haven't noticed there are several places which use this check.

I closed this pull request for now.
I would open another pull request if I could make modifications for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants