Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

less_io to debug #1035

Merged
merged 4 commits into from
Sep 20, 2024
Merged

less_io to debug #1035

merged 4 commits into from
Sep 20, 2024

Conversation

VGPReys
Copy link
Contributor

@VGPReys VGPReys commented Sep 19, 2024 •
edited
Loading

Checklist

  • Tests added for the new code
  • Documentation added for the code changes
  • Does not break licensing
  • Does not add any dependencies, if it does please add a thorough explanation

Summary of the Pull Request

Modify parameter name less_io to debug, and inverse conditions using this parameter.

Related Issue

Closes #1033

@VGPReys VGPReys self-assigned this Sep 19, 2024
@VGPReys VGPReys added the enhancement Enhancing an existing feature of adding a new one label Sep 19, 2024
rvhonorato
rvhonorato previously approved these changes Sep 19, 2024
View reviewed changes
@VGPReys VGPReys requested a review from a team September 19, 2024 12:34
amjjbonvin
amjjbonvin reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@amjjbonvin amjjbonvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And may-be we should change the default for debug from true to false. For sure the production release

src/haddock/modules/analysis/caprieval/capri.py Outdated Show resolved Hide resolved
mgiulini
mgiulini previously approved these changes Sep 20, 2024
View reviewed changes
@VGPReys VGPReys merged commit 9d294f4 into main Sep 20, 2024
3 checks passed
@VGPReys VGPReys deleted the lessio-to-dubug branch September 20, 2024 10:49
sverhoeven added a commit to i-VRESSE/workflow-builder that referenced this pull request Sep 20, 2024
@sverhoeven
regen catalogs: less_io 2 debug
2e0acda 
See haddocking/haddock3#1035
@sverhoeven sverhoeven mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amjjbonvin amjjbonvin amjjbonvin approved these changes

@mgiulini mgiulini mgiulini approved these changes

@rvhonorato rvhonorato rvhonorato left review comments

Assignees

@VGPReys VGPReys

Labels
enhancement Enhancing an existing feature of adding a new one
Projects
haddock3 release candidate
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify less_io parameter name to debug
4 participants
@VGPReys @amjjbonvin @rvhonorato @mgiulini