Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: actions のりファクタ #129

Merged
merged 8 commits into from
Jan 31, 2024
Merged

fix: actions のりファクタ #129

merged 8 commits into from
Jan 31, 2024

Conversation

mew-ton
Copy link
Contributor

@mew-ton mew-ton commented Jan 31, 2024

Summary by CodeRabbit

  • 新機能
    • ワークフロー実行の名前をイベントトリガーに基づいて動的に設定する新しい機能を追加しました。
  • 改善点
    • 特定の条件下でのinit__nodeジョブの実行をスキップする条件を追加しました。
    • init__nodeジョブのトリガー条件を変更しました。以前はプルリクエストのラベルに関連する条件が満たされた場合にジョブがトリガーされましたが、変更後は'renovate'ラベルがない場合、またはプルリクエストのタイトルが'Version Packages'でない場合にトリガーされます。

Copy link

changeset-bot bot commented Jan 31, 2024

⚠️ No Changeset found

Latest commit: 10099a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

coderabbitai bot commented Jan 31, 2024

Walkthrough

GitHub Actionsのワークフローが更新され、新しいrun-nameフィールドが追加され、特定条件下でのジョブ実行スキップが導入されました。これにより、ワークフローの柔軟性と効率が向上しています。

Changes

ファイルパス 変更概要
.github/workflows/.../codspeed.yml
.github/workflows/.../test.yml
run-nameフィールドの追加、init__nodeジョブの条件ロジック変更
.github/workflows/.../lint__codebase.yml ジョブ名とrun-nameの変更、ジョブ実行条件の修正
.changeset/config.json config.jsonファイルのchangelogプロパティのリフォーマット
tsup.config.ts コメント追加とesbuildOptionsオブジェクトへの末尾カンマの追加

🐇✨
変更来たる、新たな朝に
コードの海、航海する
ラベルなき船、帆を上げ
バージョンの風、新たな道を切り開く
🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7862213 and 3b84a10.
Files selected for processing (2)
  • .github/workflows/codspeed.yml (2 hunks)
  • .github/workflows/test.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/test.yml

.github/workflows/codspeed.yml Outdated Show resolved Hide resolved
.github/workflows/codspeed.yml Outdated Show resolved Hide resolved
@mew-ton mew-ton closed this Jan 31, 2024
@mew-ton mew-ton reopened this Jan 31, 2024
@mew-ton mew-ton closed this Jan 31, 2024
@mew-ton mew-ton reopened this Jan 31, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 3b84a10 and 10099a6.
Files ignored due to path filters (1)
  • biome.json is excluded by: !**/*.json
Files selected for processing (5)
  • .changeset/config.json (1 hunks)
  • .github/workflows/codspeed.yml (2 hunks)
  • .github/workflows/lint__codebase.yml (2 hunks)
  • .github/workflows/test.yml (2 hunks)
  • tsup.config.ts (2 hunks)
Files skipped from review due to trivial changes (3)
  • .changeset/config.json
  • .github/workflows/lint__codebase.yml
  • tsup.config.ts
Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/codspeed.yml
  • .github/workflows/test.yml

Copy link

codspeed-hq bot commented Jan 31, 2024

CodSpeed Performance Report

Merging #129 will not alter performance

Comparing fix/actions (10099a6) with main (7862213)

Summary

✅ 22 untouched benchmarks

@mew-ton mew-ton merged commit cc6c374 into main Jan 31, 2024
8 checks passed
@mew-ton mew-ton deleted the fix/actions branch January 31, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant