feat: type-level let #684
Merged
feat: type-level let #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brprice
force-pushed
the
brprice/let-type
branch
3 times, most recently
from
6b8c8c7 to
6bc3080
Compare
|
This unblocks #559 |
|
Just so I understand, this is so we can represent substitution of type lambdas during eval as |
dhess
approved these changes
Sep 12, 2022
|
georgefst
approved these changes
Sep 12, 2022
Similarly to 'lettype', these will be unsupported in the typechecker. It is expected that (for now) they are only ephemeral nodes used during evaluation. However, this commit does not implement support in the evaluators or generators. (It does implement support everywhere other than the typechecker, the evaluators and the generators.)
We also draft support for type-level lets in the typed generator. However, this is commented out because the typechecker does not support lets in types.
brprice
force-pushed
the
brprice/let-type
branch
from
6bc3080 to
09c5541
Compare
Note that this only handles lets that somehow already appear in types -- we do not create them. (In fact, because Eval drops the relevent annotations (in BETA redexes), we don't have any place we want to use such lets).
Note that this only handles lets that somehow already appear in types -- we do not create them.
brprice
force-pushed
the
brprice/let-type
branch
from
09c5541 to
3fed105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support lets in types to the same extent as typelet in terms. Use them when doing a BETA reduction (in EvalFull).