Skip to content

Commit

Permalink
chore(hole/annotation elision): link to github bug tracker (#1147)
Browse files Browse the repository at this point in the history
  • Loading branch information
brprice authored Sep 19, 2023
2 parents 2bf2349 + ec5f510 commit 3a3f53c
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions primer/src/Primer/Typecheck.hs
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,14 @@ check t = \case
-- this can lead to the output being the same as the input, but with
-- ID of the top hole changed, leading to losing cursor positions etc.
-- But we do want to remove nested holes.
--
-- TODO: There are known issues with this logic, see
-- - https://github.com/hackworthltd/primer/issues/7
-- (the general issue)
-- - https://github.com/hackworthltd/primer/pull/1120#discussion_r1329972556
-- (we noticed a specific strange behavior where a redundant
-- holey annotation was not elide even though it was identical to
-- the outer type information: foo : ∀a:*.? ; foo = {? ? : ∀a:*.? ?}
(Hole _ e'@Hole{}, SmartHoles) ->
check t e' -- we strip off one layer, and hit this case again.
(Hole _ (Ann _ e' TEmptyHole{}), SmartHoles) ->
Expand Down

0 comments on commit 3a3f53c

Please sign in to comment.