Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nodejs): upgrade to Storybook 8 #1158

Merged
merged 2 commits into from
May 5, 2024
Merged

chore(nodejs): upgrade to Storybook 8 #1158

merged 2 commits into from
May 5, 2024

Conversation

dhess
Copy link
Member

@dhess dhess commented Apr 10, 2024

No description provided.

@dhess dhess self-assigned this Apr 10, 2024
@dhess dhess added WIP A work in progress, not ready for merging Do not merge Do not merge labels Apr 10, 2024
@dhess
Copy link
Member Author

dhess commented Apr 10, 2024

This is very much a WIP:

  • It doesn't render at all on Safari when running pnpm storybook — the "chunks" served up by the proxy return 404's. It works fine on Firefox and Chrome on macOS.
  • The automatic on* handlers for basic interactive testing of actions in the UI has been replaced by a much more cumbersome system where you have to, at the very least, write stub functions for every action on every component. This is going to be quite a bit of work for us. I've started this work in this PR, but there is much left to be done. It sounds like this change has been made with an eye towards more robust testing of actions in Storybook, which is unfortunate for us, as we have no intention of using Storybook for this purpose. The only testing we do in Storybook is a quick automated visual diff when we upgrade libraries etc. I don't think it's a suitable environment for anything more robust; at the very least, I don't think we want to increase our dependency on it.

I'm posting this PR with the expectation that I may find time to work on it here and there, and maybe eventually finish the upgrade, but it seems just as likely that we'll ditch it, as Storybook seems to be moving in a direction we don't particularly care to follow.

This used to be the default pre-Storybook 8, but now the default is
`react-docgen`, which isn't as accurate.

Signed-off-by: Drew Hess <[email protected]>
@dhess
Copy link
Member Author

dhess commented May 5, 2024

The Safari rendering issue appears to be fixed with the latest version of Storybook, and it turns out that the old automatically-generated on* handler schema still works — it's just deprecated. Therefore, I think this is now in good enough shape to merge. We can migrate to new Storybook 8 features etc. at our leisure, rather than all at once in a mega-PR.

@dhess dhess added this pull request to the merge queue May 5, 2024
@dhess dhess removed WIP A work in progress, not ready for merging Do not merge Do not merge labels May 5, 2024
Merged via the queue into main with commit f68475b May 5, 2024
33 checks passed
@dhess dhess deleted the dhess/storybook-8 branch May 5, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant