Bump Primer pin for edge flavor support #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This backend version outputs flavors for edges. Here we make the minimum changes in order to get this codebase to compile. Making use of the flavors in order to provide visual labels on edges is left for future work. Note that the examples in `trees.ts` have been updated so that they typecheck, but rather than laboriously choosing the correct edge flavors we just use `"Hole"` everywhere. Signed-off-by: George Thomas <[email protected]>
dhess
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that #1097 is non-trivial, I've opted to split out the necessary changes to get us using the latest backend, in order to avoid any awkward conflicts with other work.