Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animations #1077

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Animations #1077

merged 1 commit into from
Nov 22, 2023

Conversation

georgefst
Copy link
Contributor

@georgefst georgefst commented Oct 17, 2023 •
edited
Loading

This is currently using hackworthltd/primer#1169, so that we can experiment more freely.

@georgefst georgefst added the Deploy service Deploy the backend service for this PR label Oct 17, 2023
@georgefst georgefst marked this pull request as draft October 17, 2023 15:45
@georgefst georgefst force-pushed the georgefst/animations branch from b119c59 to 2713a3b Compare October 17, 2023 16:16
@georgefst georgefst added Deploy service Deploy the backend service for this PR and removed Deploy service Deploy the backend service for this PR labels Oct 17, 2023
@dhess dhess force-pushed the georgefst/animations branch from 1d02032 to 55504b0 Compare October 24, 2023 16:00
@dhess dhess added Deploy service Deploy the backend service for this PR and removed Deploy service Deploy the backend service for this PR labels Oct 24, 2023
@georgefst georgefst force-pushed the georgefst/animations branch from 55504b0 to 27f3bb0 Compare October 30, 2023 12:10
@georgefst georgefst added Deploy service Deploy the backend service for this PR and removed Deploy service Deploy the backend service for this PR labels Oct 30, 2023
@georgefst georgefst force-pushed the georgefst/animations branch from 27f3bb0 to 459384e Compare October 30, 2023 19:32
@georgefst georgefst added Deploy service Deploy the backend service for this PR and removed Deploy service Deploy the backend service for this PR labels Oct 31, 2023
@georgefst
feat: Support animations
9c4578c 
This just involves bumping the backend pin and adding a new node type for rendering for the new animation primitive.

Signed-off-by: George Thomas <[email protected]>
@georgefst georgefst force-pushed the georgefst/animations branch from 459384e to 9c4578c Compare November 22, 2023 14:18
@georgefst georgefst marked this pull request as ready for review November 22, 2023 14:18
@georgefst georgefst requested a review from a team November 22, 2023 14:18
@georgefst georgefst added Deploy service Deploy the backend service for this PR and removed Deploy service Deploy the backend service for this PR labels Nov 22, 2023
@georgefst georgefst added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 6c8719c Nov 22, 2023
26 of 27 checks passed
@georgefst georgefst deleted the georgefst/animations branch November 22, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhess dhess dhess approved these changes

Assignees
No one assigned
Labels
Deploy service Deploy the backend service for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgefst @dhess