Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream issue preventing migration to TypeScript 5.x #898

Closed
dhess opened this issue May 27, 2023 · 0 comments · Fixed by #1150
Closed

Upstream issue preventing migration to TypeScript 5.x #898

dhess opened this issue May 27, 2023 · 0 comments · Fixed by #1150
Labels
blocked/upstream ❌ Blocked by upstream issue meta An issue about the project or repo, not its contents TypeScript TypeScript issue

Comments

@dhess
Copy link
Member

dhess commented May 27, 2023

See:
@dhess dhess added TypeScript TypeScript issue blocked/upstream ❌ Blocked by upstream issue meta An issue about the project or repo, not its contents labels May 27, 2023
dhess added a commit that referenced this issue Apr 10, 2024
@dhess
chore(typescript): disable exactOptionalPropertyTypes
5bbf5e3 
This setting is causing problems for us with one package we'd like to
use:

#1012 (comment)

and is also preventing us from migrating to TypeScript 5 due to an
upstream issue in `react-router` that's been unaddressed for almost a
year:

#898

There were no objections to disabling it, so we do so in this commit.
(There is one minor code change required as a result, just an
additional optional property check on a `onNodeClick` handler in our
React Flow wrapper.)

Signed-off-by: Drew Hess <[email protected]>
dhess added a commit that referenced this issue Apr 10, 2024
@dhess
chore(typescript): disable exactOptionalPropertyTypes
b1a079b 
This setting is causing problems for us with one package we'd like to
use:

#1012 (comment)

and is also preventing us from migrating to TypeScript 5 due to an
upstream issue in `react-router` that's been unaddressed for almost a
year:

#898

There were no objections to disabling it, so we do so in this commit.
(There is one minor code change required as a result, just an
additional optional property check on a `onNodeClick` handler in our
React Flow wrapper.)

Closes #898

Signed-off-by: Drew Hess <[email protected]>
@dhess dhess mentioned this issue Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked/upstream ❌ Blocked by upstream issue meta An issue about the project or repo, not its contents TypeScript TypeScript issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(typescript): disable exactOptionalPropertyTypes hackworthltd/primer-app
1 participant
@dhess