Skip to content

Commit

Permalink
chore: switch to ES modules
Browse files Browse the repository at this point in the history
Sadly, quite a few of our tools don't support ES modules, so we need
to rename a few things to `.cjs`. Sigh.

Also, we don't need the `PkgConfig` plugin for Vite, which also a)
doesn't work with ES modules and b) isn't maintained anymore, anyway.

Signed-off-by: Drew Hess <[email protected]>
  • Loading branch information
dhess committed Apr 10, 2024
1 parent 53e3976 commit 6c59df7
Show file tree
Hide file tree
Showing 8 changed files with 29 additions and 9 deletions.
File renamed without changes.
File renamed without changes.
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"node": "^18.6.0 || ^19.0 || ^20.0",
"pnpm": "^8.5"
},
"type": "module",
"scripts": {
"watch": "vite",
"build": "vite build",
Expand Down Expand Up @@ -79,6 +80,7 @@
"orval": "^6.26.0",
"postcss": "^8.4.38",
"postcss-import": "^16.1.0",
"postcss-load-config": "^5.0.3",
"prettier": "^3.2.5",
"storybook": "^7.5.1",
"tailwindcss": "3.4.3",
Expand Down
20 changes: 20 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions postcss.config.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
module.exports = {
plugins: {
tailwindcss: {} || null,
autoprefixer: {} || null,
},
};
6 changes: 0 additions & 6 deletions postcss.config.js

This file was deleted.

2 changes: 1 addition & 1 deletion tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"lib": ["DOM", "DOM.Iterable", "ESNext"],
"allowJs": false,
"skipLibCheck": false,
"esModuleInterop": false,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
Expand Down
2 changes: 0 additions & 2 deletions vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { defineConfig, loadEnv } from "vite";
import svgr from "vite-plugin-svgr";
import react from "@vitejs/plugin-react";
import { checker } from "vite-plugin-checker";
import PkgConfig from "vite-plugin-package-config";
import tsconfigPaths from "vite-tsconfig-paths";
import vitePluginFaviconsInject from "vite-plugin-favicons-inject";

Expand All @@ -22,7 +21,6 @@ export default ({ mode }) => {
react(),
svgr(),
tsconfigPaths(),
PkgConfig(),
// Can cause issues in development mode, and with Storybook builds. See:
// https://github.com/JohnPremKumar/vite-plugin-favicons-inject#development-mode
process.env.VITE_API_URL !== ""
Expand Down

0 comments on commit 6c59df7

Please sign in to comment.