fix: Use non-empty edge IDs in React Flow trees

hackworthltd · Jun 2, 2022 · 255d6ce · 255d6ce
1 parent d147412
commit 255d6ce
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/packages/primer-components/src/TreeReactFlow/TreeReactFlow.tsx b/packages/primer-components/src/TreeReactFlow/TreeReactFlow.tsx
@@ -24,11 +24,14 @@ const convertTree = (
     data: { label: tree.label },
     position: { x, y },
   };
-  const thisToChildren: Edge[] = tree.childTrees.map((t) => ({
-    id: "",
-    source: id,
-    target: t.nodeId.toString(),
-  }));
+  const thisToChildren: Edge[] = tree.childTrees.map((t) => {
+    const target = t.nodeId.toString();
+    return {
+      id: JSON.stringify([id, target]),
+      source: id,
+      target,
+    };
+  });
   return {
     nodes: [thisNode, ...children.flatMap(({ nodes }) => nodes)],
     edges: [...thisToChildren, ...children.flatMap(({ edges }) => edges)],