Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting errors - component-library #468

Merged
merged 8 commits into from
Apr 29, 2019
Merged

Fix linting errors - component-library #468

merged 8 commits into from
Apr 29, 2019

Conversation

jaronheard
Copy link
Contributor

@jaronheard jaronheard commented Apr 11, 2019 •
edited by mendozaline
Loading

Let the linting begin!

  • implemented prettier hook using lint-staged
  • added lint script to package.json in each package
  • fixed 350+ linting errors in component-library
  • removed some unused files in component-library (leaflet.css, stories)

Next steps:

  • lint all other packages - in other PR

Follow-up issues for component library

  • make PropTypes.shape({}) validation more useful for component library by adding object shapes
  • ensure accessibility of SandboxToggleSwitch

@jaronheard jaronheard mentioned this pull request Apr 12, 2019
Merged
mendozaline
mendozaline approved these changes Apr 28, 2019
View reviewed changes
Copy link
Member

@mendozaline mendozaline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's get this merged before the Civic Sandbox Dashboard PR because I think there will be merge conflicts with this.

@jaronheard jaronheard merged commit 0146305 into master Apr 29, 2019
@jaronheard jaronheard mentioned this pull request May 9, 2019
Closed
11 tasks
@jaronheard jaronheard deleted the lint branch July 14, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mendozaline mendozaline mendozaline approved these changes

Assignees

@mendozaline mendozaline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaronheard @mendozaline