-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for LDAP server authentication #279
Merged
Merged
Commits on Dec 13, 2016
-
Initial support for LDAP server authentication
Limitations as of this commit: - tlsOptions can only be specified in config.json, not as env vars - authentication failures are not yet gracefully handled by the UI - instead the error message is shown on a blank page (/auth/ldap) - no email address is associated with the LDAP user's account - no picture/profile URL is associated with the LDAP user's account - we might have to generate our own access + refresh tokens, because we aren't using oauth. The currently generated tokens are just a placeholder. - 'LDAP Sign in' needs to be translated to each locale
Configuration menu - View commit details
-
Copy full SHA for 02e9927 - Browse repository at this point
Copy the full SHA 02e9927View commit details
Commits on Dec 14, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 6ba9a2f - Browse repository at this point
Copy the full SHA 6ba9a2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3007163 - Browse repository at this point
Copy the full SHA 3007163View commit details -
- return bad request if no username or password given - return to referer url on auth success - flash error message on auth failure
Configuration menu - View commit details
-
Copy full SHA for fc8d709 - Browse repository at this point
Copy the full SHA fc8d709View commit details -
LDAP signin form moved to main signin-modal
- previously was a separate modal - now is located on main modal, like email auth
Configuration menu - View commit details
-
Copy full SHA for 72a0e90 - Browse repository at this point
Copy the full SHA 72a0e90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3491f97 - Browse repository at this point
Copy the full SHA 3491f97View commit details
Commits on Jan 6, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 01361af - Browse repository at this point
Copy the full SHA 01361afView commit details -
Configuration menu - View commit details
-
Copy full SHA for b044c2a - Browse repository at this point
Copy the full SHA b044c2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4fe932 - Browse repository at this point
Copy the full SHA e4fe932View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94abfab - Browse repository at this point
Copy the full SHA 94abfabView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.