Write note to filesystem if file exists #1504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniele Ricci <[email protected]>
daniele-athome
force-pushed
the
pr/feature/write-fs
branch
from
c1e0837
to
c21ae75
Compare
|
Hi @daniele-athome, |
|
I'm sorry but I stopped using CodiMD 😢 |
It's ok 😃 , hope you doing good. |
|
If anyone likes to continue develop this feature, welcome to open another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch writes note content back to the filesystem if a file exists in the public docs path. This can be a first step towards the real objective of #90 maybe?
Please note that this doesn't address the fact that notes loaded from docsPath are set with a null user owner ID so they are not actually editable. You need to update the row in the database for that. I believe that part should be addressed in another way (I was thinking something like per-user docsPath)