Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: arbitrary file upload (i.e. zip / doc / pdf / stl) #261

Open
ccoenen opened this issue Nov 27, 2016 · 6 comments
Open

Enhancement: arbitrary file upload (i.e. zip / doc / pdf / stl) #261

ccoenen opened this issue Nov 27, 2016 · 6 comments
Labels
enhancement Wants to improvide an existing feature Hacktoberfest help wanted We want you to help us with this!

Comments

@ccoenen
Copy link
Contributor

ccoenen commented Nov 27, 2016

As discussed in the image upload pull request, I'd love to see this extended to arbitrary files. If I drag in an image, it becomes an image tag, if it's any other filetype, it becomes a regular Link.

@jackycute jackycute added the enhancement Wants to improvide an existing feature label Nov 29, 2016
@Yukaii Yukaii added this to the Backlog milestone Feb 27, 2017
@SISheogorath
Copy link
Contributor

This sounds possible and not too complicated with integrated object storage like S3 and with #506 it should be possible for all self-hosted instance. The default imgur doesn't allow to do so.

Here is a place to start if we are looking for an implementation:

https://github.com/hackmdio/hackmd/blob/3b8f4bc1a256733361e29be16a48e39d41f7c420/lib/web/imageRouter.js#L41-L75

@grmpyninja
Copy link

it might make sense to extend a little bit S3 integration and allow to use custom S3-compatible software like https://github.com/minio/minio

it'd be both secure (self-hosted version) and universal.

@SISheogorath
Copy link
Contributor

SISheogorath commented Oct 9, 2017

@grmpyninja That's exactly what #506 is about ;)

Once it's merged, we can extend this as well, yes.

@SISheogorath
Copy link
Contributor

Now #506 is merged and also #691 provides a basic possibility to extend uploads. Of course there are some changes needed as pdfs shouldn't be embedded as pictures, but the potential is there.

Only an implementation is missing. Contributions are welcome 👍

@SISheogorath SISheogorath added the help wanted We want you to help us with this! label Jan 31, 2018
@SISheogorath SISheogorath removed this from the Backlog milestone Mar 23, 2019
@lephix
Copy link

lephix commented May 28, 2019

Is this feature still developing?

JJediny pushed a commit to 18F/codimd-cloudgov-template that referenced this issue Dec 16, 2020
…te-libravatar

Changed Gravatar to Libravatar in privacy-template
@aslmx
Copy link

aslmx commented Mar 22, 2021

I'd also love to see this feature. Any news? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Wants to improvide an existing feature Hacktoberfest help wanted We want you to help us with this!
Projects
None yet
Development

No branches or pull requests

7 participants