Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add teamId to expansion of query result, and keep team member ids in … #300

Merged
merged 15 commits into from
Jan 22, 2019
Merged

Add teamId to expansion of query result, and keep team member ids in … #300

merged 15 commits into from
Jan 22, 2019

Conversation

pierreTklein
Copy link
Member

…get team

Description

  • getTeam does not return hacker IDs of other hackers in the team, but we might as well have them; there is no real harm in doing so.
  • Populate teamId if expand in search is set to true.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Updated existing test for teams.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

YiFeiZhang2
YiFeiZhang2 reviewed Jan 22, 2019
View reviewed changes
docs/api/api_data.js
@@ -1257,7 +1257,7 @@ define({
},
{
"type": "get",
"url": "/hacker/email/:email",
"url": "/hacker/:id",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused as to where these changes are coming from. Was this from a previous PR where docs wasn't updated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea, probably just ordering of the items in the list

YiFeiZhang2
YiFeiZhang2 reviewed Jan 22, 2019
View reviewed changes
docs/api/api_data.js
}]
},
{
"type": "get",
"url": "/hacker/:id",
"url": "/hacker/email/:email",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also kind of weird that in some cases we remove :id to add email/:email, and above we removed email/:email to add :id

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@pierreTklein pierreTklein merged commit 24bf4c5 into develop Jan 22, 2019
pierreTklein added a commit that referenced this pull request Jan 30, 2019
@pierreTklein
Develop to master (#322)
52bb649 
* Bump @types/express from 4.11.1 to 4.16.1

Bumps [@types/express](https://github.com/DefinitelyTyped/DefinitelyTyped) from 4.11.1 to 4.16.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump mongoose from 5.4.5 to 5.4.6

Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.4.5 to 5.4.6.
- [Release notes](https://github.com/Automattic/mongoose/releases)
- [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md)
- [Commits](Automattic/mongoose@5.4.5...5.4.6)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump @types/mongoose from 5.3.8 to 5.3.9

Bumps [@types/mongoose](https://github.com/DefinitelyTyped/DefinitelyTyped) from 5.3.8 to 5.3.9.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits)

Signed-off-by: dependabot[bot] <[email protected]>

* Add batch script to update hacker statuses (#308)

* Add teamId to expansion of query result, and keep team member ids in … (#300)

* Add teamId to expansion of query result, and keep team member ids in get team

* Update test

* Update comments

* doc updates

* Bug fix

* ObjectId object -> string

* accountId -> hackerId

* _id -> .toString()

* Bump @types/mongoose from 5.3.9 to 5.3.10

Bumps [@types/mongoose](https://github.com/DefinitelyTyped/DefinitelyTyped) from 5.3.9 to 5.3.10.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump mongoose from 5.4.6 to 5.4.7

Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.4.6 to 5.4.7.
- [Release notes](https://github.com/Automattic/mongoose/releases)
- [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md)
- [Commits](Automattic/mongoose@5.4.6...5.4.7)

Signed-off-by: dependabot[bot] <[email protected]>

* Feature/ticket email (#313)

* WIP

* Finish route

* Add docs

* Add tests

* Switch to member who has confirmed

* Fix test

* Remove line

* Change URL of QR code

* Bump qrcode from 1.3.2 to 1.3.3

Bumps [qrcode](https://github.com/soldair/node-qrcode) from 1.3.2 to 1.3.3.
- [Release notes](https://github.com/soldair/node-qrcode/releases)
- [Changelog](https://github.com/soldair/node-qrcode/blob/master/CHANGELOG.md)
- [Commits](soldair/node-qrcode@v1.3.2...v1.3.3)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump jslint from 0.12.0 to 0.12.1

Bumps [jslint](https://github.com/reid/node-jslint) from 0.12.0 to 0.12.1.
- [Release notes](https://github.com/reid/node-jslint/releases)
- [Changelog](https://github.com/reid/node-jslint/blob/master/CHANGELOG.md)
- [Commits](reid/node-jslint@v0.12.0...v0.12.1)

Signed-off-by: dependabot[bot] <[email protected]>

* Add search to sponsor (#317)

* Add search to sponsor

* Give sponsors full hacker, account permissions

* Bump @google-cloud/storage from 2.3.1 to 2.4.1

Bumps [@google-cloud/storage](https://github.com/googleapis/nodejs-storage) from 2.3.1 to 2.4.1.
- [Release notes](https://github.com/googleapis/nodejs-storage/releases)
- [Changelog](https://github.com/googleapis/nodejs-storage/blob/master/CHANGELOG.md)
- [Commits](googleapis/nodejs-storage@v2.3.1...v2.4.1)

Signed-off-by: dependabot[bot] <[email protected]>

* Update week-of email (#321)

* Bump mongoose from 5.4.7 to 5.4.8

Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.4.7 to 5.4.8.
- [Release notes](https://github.com/Automattic/mongoose/releases)
- [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md)
- [Commits](Automattic/mongoose@5.4.7...5.4.8)

Signed-off-by: dependabot[bot] <[email protected]>
@loreina loreina deleted the bugfix/addTeamMemberIds branch July 30, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YiFeiZhang2 YiFeiZhang2 YiFeiZhang2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierreTklein @YiFeiZhang2