Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: using path.join instead of concatenate path strings directly. #474

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Fix: using path.join instead of concatenate path strings directly. #474

merged 1 commit into from
Jan 22, 2021

Conversation

PMExtra
Copy link
Contributor

@PMExtra PMExtra commented Jan 18, 2021

Although Windows API support both forward slash and backslash. But in common sense, Windows should use forward slash as path separator, especially cmd and other command shells usually doesn't support backslash. So the most robust solution is follow the os specified path separator, we can use path.join to implement it.

The most important is that, Lepton has shown the config path in UI (About dialog). For now, it shown mixed path separators in one path, it makes user confused. So I fixed it.

Expected (after this fix):
expect

Actual (before this fix):
actual

@hackjutsu
Copy link
Owner

That's pretty cool. Thanks for making the change!

@hackjutsu hackjutsu merged commit a403ce4 into hackjutsu:master Jan 22, 2021
@hackjutsu
Copy link
Owner

@all-contributors please add @PMExtra for code

@allcontributors
Copy link
Contributor

@hackjutsu

I've put up a pull request to add @PMExtra! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants