Fix: using path.join instead of concatenate path strings directly. #474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although Windows API support both forward slash and backslash. But in common sense, Windows should use forward slash as path separator, especially cmd and other command shells usually doesn't support backslash. So the most robust solution is follow the os specified path separator, we can use
path.join
to implement it.The most important is that, Lepton has shown the config path in UI (About dialog). For now, it shown mixed path separators in one path, it makes user confused. So I fixed it.
Expected (after this fix):
Actual (before this fix):