Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure notifications by type #422

Merged
merged 7 commits into from
Jun 2, 2020
Merged

Configure notifications by type #422

merged 7 commits into from
Jun 2, 2020

Commits on Jun 1, 2020

  1. Document notifications are a configurable setting

    @dideler
    dideler committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    ac48e78 View commit details
    Browse the repository at this point in the history

  2. Git ignore VSCode config

    @dideler
    dideler committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    8dcc986 View commit details
    Browse the repository at this point in the history

  3. Add new defaults for notification config 

    The previous setting "disableNotification" isn't extendable.
There's no hierarchy to group notification settings. New notification
settings would end up as a top-level config, which isn't consistent with
existing configuration structure.
    @dideler
    dideler committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    4582b69 View commit details
    Browse the repository at this point in the history

  4. Export success and failure notification functions 

    By classifying the type of notification, we can treat them differently.
For now it's only whether to show the notification type, but in the
future can also do things such as styling, formatting, content, etc.
    @dideler
    dideler committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    2cc3dad View commit details
    Browse the repository at this point in the history

  5. Use success and failure notifications

    @dideler
    dideler committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    e9fbca3 View commit details
    Browse the repository at this point in the history

  6. Remove disableNotification configuration

    @dideler
    dideler committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    b08ed67 View commit details
    Browse the repository at this point in the history

  7. Link to the new wiki page for configuring Lepton

    @dideler
    dideler committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    557a160 View commit details
    Browse the repository at this point in the history