Fix maximum element failure #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ml-evs Any ideas where the failures could come from? To dig into this, I would need to fix the installation locally first as well. Okay, I see... there are simply tons of failing tests 😅 ... |
|
Hi @JaGeo, the changes in this PR look fine to me, the failing tests are simply from the lack of pandas 2.0 support (and the rest are passing fine for me locally). If you did want to verify this yourself, you can install the pinned deps in the various requirements files in this repo rather than using the loose pyproject versions. |
ml-evs
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #920 by introducing a maximum element number. Og is probably enough.