Add GitHub profile picture from github-data.json #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you go ahead and change the css file to make it the image look more similar |
|
CSS to alter height and width have now been removed |
trtincher
reviewed
Jan 18, 2021
wins.html
Outdated
| /* if github url is provided in wins-data and permission | ||
| is granted, ghId is defined & we can use their github avatar */ | ||
|
|
||
| let githubAvaUrl = ghId ? |
There was a problem hiding this comment.
this might be cleaner if you wrote it something like this.
let githubAvaUrl = `https://avatars1.githubusercontent.com/u/${ghId}?v=4`;
let defaultAvaUrl = "/assets/images/wins-page/avatar-default.svg"
let profileImgSrc = ghId ? githubAvaUrl : defaultAvaUrl;
There was a problem hiding this comment.
what if we just resolve that to one line with a comment? i.e.
/* if github url is provided in wins-data and permission
is granted, ghId is defined & we can use their github avatar
otherwise, use default avatar */
let profileImgSrc = ghId ?
`https://avatars1.githubusercontent.com/u/${ghId}?v=4` :
"/assets/images/wins-page/avatar-default.svg";
There was a problem hiding this comment.
Yeah I think that is a great solution as well.
There was a problem hiding this comment.
awesome, pushed a new commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #925
See issue comments for screenshots and additional issues