Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced label in img-tag-refactor-on-website.md #7791

Conversation

Sujay-Anantha
Copy link
Member

@Sujay-Anantha Sujay-Anantha commented Dec 4, 2024

Fixes #7604

What changes did you make?

  • Replaced ready for dev lead label with ready for merge team label in the file /.github/ISSUE_TEMPLATE/img-tag-refactor-on-website.md

Why did you make the changes (we will use this info to test)?

  • To change the ready for label on the img-tag-refactor-on-website.md issue template so that the merge team can handle more of the issue reviews.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

For Reviewers

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 1pt Can be done in 4-6 hours labels Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Sujay-Anantha-replace-label-img-tag-refactor-on-website-7604 gh-pages
git pull https://github.com/Sujay-Anantha/website.git replace-label-img-tag-refactor-on-website-7604

@codyyjxn codyyjxn self-requested a review December 5, 2024 04:25
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sujay-Anantha thank you for taking on this issue.

Things that went well

  • The title is correct
  • The branch name is correct
  • The changes are made correct as well

Keep it up!

@siyunfeng siyunfeng self-requested a review December 7, 2024 03:12
@siyunfeng
Copy link
Member

Review ETA: 12/6/2024 Friday
Availability: 6-9 PM Weekdays (EDT)

Copy link
Member

@siyunfeng siyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job working on this issue, @Sujay-Anantha !

You did well on these:

  • The original issue is linked
  • Availability and ETA are provided in the original issue
  • The change you made in the corresponding file is accurate
  • The CodeQL Alerts are checked
  • The URL of the updated issue template is correct
  • The change is applied to the updated issue template
  • The corresponding labels match the updated issue template

Things to improve:

  • Provide the corresponding answer to the Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes) section. If there are visual changes to the website, include the before-and-after screenshots. Otherwise, keep the - No visual changes to the website from the Notes.

Reminder:

  • After PR is merged, follow the instructions in the original issue to change your default branch back to gh-pages and disable the Issues feature

Thank you for your contribution!

@FamousHero FamousHero merged commit 8290db6 into hackforla:gh-pages Dec 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging this pull request may close these issues.

Replace label in img-tag-refactor-on-website.md
4 participants