-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile: LA TDM Calculator Remove Ebi Imafidon #7728
Update Project Profile: LA TDM Calculator Remove Ebi Imafidon #7728
Conversation
- Remove Ebi Imafidon from Current Project Team
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 3 PM 11/19/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic job, @bmugdhchauhan!
Everything looks great to me.
- The branch name includes the issue number and clearly describes the work you did.
- The issue is linked correctly.
- Before-and-after screenshots are provided to demonstrate the changes.
- The code changes are accurate.
- CodeQL alerts have been checked.
Thank you for your contribution! Keep up the excellent work!
Review ETA: 6 PM 11/19/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @bmugdhchauhan, Everything looks awesome!
- The branch you work on is correct, the branch name is clear.
- The linked issue number is included.
- Availability and ETA are provided.
- The change you made is correct.
- Before-and-after screenshots match the frontend view.
- CodeQL alerts have been checked.
Keep up with the great work!
Thank you @trimakichan and @mamypoco |
Fixes #7650
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied