Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Profile: LA TDM Calculator Remove Ebi Imafidon #7728

Conversation

mugdhchauhan
Copy link
Member

@mugdhchauhan mugdhchauhan commented Nov 19, 2024

Fixes #7650

What changes did you make?

  • Update Project Profile for LA TDM Calculator by removing Ebi Imafidon from the Current Project Team

Why did you make the changes (we will use this info to test)?

  • We need to keep project information up to date so that visitors to the website can find accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Screenshot Before

Visuals after changes are applied

Screenshot After

- Remove Ebi Imafidon from Current Project Team
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b mugdhchauhan-LA-TDM-Calculator-remove-Ebi-Imafidon-7650 gh-pages
git pull https://github.com/mugdhchauhan/website.git LA-TDM-Calculator-remove-Ebi-Imafidon-7650

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 19, 2024
@trimakichan trimakichan self-requested a review November 19, 2024 16:46
@trimakichan
Copy link
Member

Review ETA: 3 PM 11/19/2024
Availability: 10-3 PM Monday - Friday

Copy link
Member

@trimakichan trimakichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job, @bmugdhchauhan!

Everything looks great to me.

  • The branch name includes the issue number and clearly describes the work you did.
  • The issue is linked correctly.
  • Before-and-after screenshots are provided to demonstrate the changes.
  • The code changes are accurate.
  • CodeQL alerts have been checked.

Thank you for your contribution! Keep up the excellent work!

@mamypoco mamypoco requested review from mamypoco and removed request for mamypoco November 19, 2024 22:04
@mamypoco
Copy link
Member

Review ETA: 6 PM 11/19/2024
Availability: 10-3 PM M-F

Copy link
Member

@mamypoco mamypoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @bmugdhchauhan, Everything looks awesome!

  • The branch you work on is correct, the branch name is clear.
  • The linked issue number is included.
  • Availability and ETA are provided.
  • The change you made is correct.
  • Before-and-after screenshots match the frontend view.
  • CodeQL alerts have been checked.

Keep up with the great work!

@mugdhchauhan
Copy link
Member Author

Thank you @trimakichan and @mamypoco

@daras-cu daras-cu merged commit 5ddcb68 into hackforla:gh-pages Nov 20, 2024
9 checks passed
@mugdhchauhan mugdhchauhan deleted the LA-TDM-Calculator-remove-Ebi-Imafidon-7650 branch November 22, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: LA TDM Calculator Remove Ebi Imafidon
4 participants