-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update project profile remove Kristelle #7721
update project profile remove Kristelle #7721
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BlakePeters99 Thank you for taking on this issue.
- The branch name is correct
- The description is great as well.
- The issue is linked correctly
- before and after screenshots are great!
Some Suggestions
- You can remove the extra bullet points
- You can also edit the title to be a bit more clear of what files you changed.
Thank you for your contribution!
Review ETA: 6 PM 11/15/2024 |
Removed unnecessary bullet points and changed description to highlight which file was changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job removing the requested person, @BlakePeters99!
@BlakePeters99 Thank you for helping this issue.
The branch name is correct
The description is great as well.
The issue is linked correctly
before and after screenshots are great!
Suggestions
I don't see CodeQL alert, so please check the section "I have checked this PR for CodeQL alerts and none were found."
Thank you for your contribution!
Fixes #7474
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied