Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Nayan Bhatt from HackforLA.org website #7717

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

jakejjoyner
Copy link
Member

Fixes #7458

What changes did you make?

  • Removed Nayan Bhatt from the YAML front matter block in _projects/website.md

Why did you make the changes (we will use this info to test)?

  • To keep list of active website project team up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Screenshot 2024-11-11 at 6 11 18 PM
Visuals after changes are applied Screenshot 2024-11-11 at 6 01 16 PM

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jakejjoyner-update-project-profile-7458 gh-pages
git pull https://github.com/jakejjoyner/website.git update-project-profile-7458

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 12, 2024
@codyyjxn codyyjxn self-requested a review November 12, 2024 17:08
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakejjoyner Great Job on this issue.

  • The branch name is correct and clear
  • The description is great for anyone to understand and see the changes on the website.
  • The changes on my end display correctly and the issue is linked as well.

Keep it up! Thank you for your contribution.

@theogguu theogguu self-requested a review November 12, 2024 21:27
Copy link
Member

@theogguu theogguu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jakejjoyner,

Thanks for taking up this issue!

  • the PR contains the correct branch
  • issue is correctly linked
  • changes are verified across browsers (firefox, edge, chrome)
  • code changes are accurate and concise
  • no other notable issues

Keep up the good work!

@jphamtv jphamtv merged commit 5324c74 into hackforla:gh-pages Nov 15, 2024
7 checks passed
@jakejjoyner jakejjoyner deleted the update-project-profile-7458 branch November 16, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: remove Nayan Bhatt from HackforLA.org Website
4 participants