Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'Github' with 'GitHub' in data-science.yml #7715

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

bexux
Copy link
Member

@bexux bexux commented Nov 10, 2024

Fixes #7416

What changes did you make?

  • Changed Github to GitHub on _data/internal/communities/data-science.yml

Why did you make the changes (we will use this info to test)?

  • The website should display proper capitalization for GitHub to match the company's branding.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

Connected file

The _data/internal/communities/data-science.yml file is used to display the Data Science community on https://www.hackforla.org/communities-of-practice. The template for the community of practice page, pages\communities-of-practice.html, does not reference the GitHub text that I have changed in this PR. The "GitHub" text that does display on this page has been hard-coded in the html template. There should be no visible changes to the page. However, if this variable is referenced in the template in future, it will have the correct capitalization.

Test

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b bexux-update-github-spelling-7416 gh-pages
git pull https://github.com/bexux/website.git update-github-spelling-7416

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice size: 1pt Can be done in 4-6 hours labels Nov 10, 2024
@bexux bexux changed the title Replace 'Github' to 'GitHub' in data-science.yml Replace 'Github' with 'GitHub' in data-science.yml Nov 10, 2024
@siyunfeng siyunfeng self-requested a review November 11, 2024 02:02
@siyunfeng
Copy link
Member

siyunfeng commented Nov 11, 2024

Review ETA: 11/10/2024 Sunday
Availability: 6-10 PM Weekdays (EDT)

Copy link
Member

@siyunfeng siyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job working on this issue, @bexux !

  • The branch you make the change on is correct
  • Availability and ETA are provided in the original issue
  • The linked issue number is included
  • The change you make is accurate
  • The CodeQL alerts are checked

I appreciate you providing the connected file and the test procedure. As you explained, there are no visible changes to the Data Science page.

  • No merge conflict when I review this PR

Thank you for your contribution!

Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bexux , thank you for taking on this issue!

  • The branch name is correct and concise with the changes you made.
  • The pr title and description is great.

Great Job Keep it up!

@jphamtv jphamtv merged commit ae08a30 into hackforla:gh-pages Nov 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging this pull request may close these issues.

Replace Github with GitHub in _data/internal/communities/data-science.yml
4 participants